Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove setRequestHeader #91

Merged
merged 1 commit into from
May 13, 2019
Merged

fix: remove setRequestHeader #91

merged 1 commit into from
May 13, 2019

Conversation

xiaoyuhen
Copy link
Contributor

@xiaoyuhen xiaoyuhen commented May 13, 2019

fix: remove setRequestHeader

Description

close #90

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@codecov-io
Copy link

Codecov Report

Merging #91 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
+ Coverage   50.48%   50.53%   +0.05%     
==========================================
  Files         124      124              
  Lines        1769     1767       -2     
==========================================
  Hits          893      893              
+ Misses        876      874       -2
Impacted Files Coverage Δ
packages/griffith-mp4/src/fetch.js 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afd476d...0eeaee6. Read the comment docs.

@xiaoyuhen xiaoyuhen merged commit a1926bf into zhihu:master May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xhr.setRequestHeader('Access-Control-Allow-Origin', '*') in mp4 plugin causes CORS error
2 participants