Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit hooks #182

Merged
merged 25 commits into from
Oct 1, 2021
Merged

Add pre-commit hooks #182

merged 25 commits into from
Oct 1, 2021

Conversation

zhiqwang
Copy link
Owner

@zhiqwang zhiqwang commented Oct 1, 2021

@zhiqwang zhiqwang added the code quality Code format and unit tests label Oct 1, 2021
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ zhiqwang
❌ pre-commit-ci[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov
Copy link

codecov bot commented Oct 1, 2021

Codecov Report

Merging #182 (07a72f3) into master (97f507d) will increase coverage by 0.31%.
The diff coverage is 98.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #182      +/-   ##
==========================================
+ Coverage   96.17%   96.48%   +0.31%     
==========================================
  Files          10       10              
  Lines         601      598       -3     
==========================================
- Hits          578      577       -1     
+ Misses         23       21       -2     
Flag Coverage Δ
unittests 96.48% <98.07%> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/test_relaying.py 100.00% <ø> (ø)
test/test_v5.py 93.33% <75.00%> (+5.83%) ⬆️
test/test_utils.py 98.38% <94.44%> (+1.56%) ⬆️
test/test_data_pipeline.py 100.00% <100.00%> (ø)
test/test_engine.py 100.00% <100.00%> (ø)
test/test_models.py 95.37% <100.00%> (-0.03%) ⬇️
test/test_models_anchor_utils.py 100.00% <100.00%> (ø)
test/test_models_common.py 100.00% <100.00%> (ø)
test/test_models_transform.py 100.00% <100.00%> (ø)
test/test_onnx.py 85.24% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97f507d...07a72f3. Read the comment docs.

@zhiqwang zhiqwang merged commit c9b5b6f into master Oct 1, 2021
@zhiqwang zhiqwang deleted the pre-commit-hooks branch October 1, 2021 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Code format and unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants