Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup AnchorGenerator and PostProcess #203

Merged
merged 15 commits into from
Dec 20, 2021
Merged

Conversation

zhiqwang
Copy link
Owner

@zhiqwang zhiqwang commented Oct 20, 2021

We refactor AnchorGenerator in this PR.

@zhiqwang zhiqwang added enhancement New feature or request code quality Code format and unit tests labels Oct 20, 2021
@zhiqwang zhiqwang closed this Nov 24, 2021
@zhiqwang zhiqwang deleted the cleanup-anchor-generator branch November 24, 2021 18:07
@zhiqwang zhiqwang restored the cleanup-anchor-generator branch November 28, 2021 17:54
@zhiqwang zhiqwang reopened this Dec 20, 2021
@CLAassistant
Copy link

CLAassistant commented Dec 20, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ zhiqwang
❌ pre-commit-ci[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

@zhiqwang zhiqwang force-pushed the cleanup-anchor-generator branch from 4bf55bb to e5e99a1 Compare December 20, 2021 10:19
@zhiqwang zhiqwang force-pushed the cleanup-anchor-generator branch from 5fdbc92 to d18a54f Compare December 20, 2021 16:52
@zhiqwang zhiqwang force-pushed the cleanup-anchor-generator branch from 92d64c7 to 8aaec51 Compare December 20, 2021 17:18
@zhiqwang zhiqwang force-pushed the cleanup-anchor-generator branch from a0ef9e7 to 3cf8abf Compare December 20, 2021 19:12
@zhiqwang zhiqwang force-pushed the cleanup-anchor-generator branch from dbb4935 to ed6a448 Compare December 20, 2021 19:31
@zhiqwang zhiqwang added the bc-breaking Backwards Incompatible Changes label Dec 20, 2021
@zhiqwang zhiqwang force-pushed the cleanup-anchor-generator branch from 87a412e to d02f537 Compare December 20, 2021 20:56
@codecov
Copy link

codecov bot commented Dec 20, 2021

Codecov Report

Merging #203 (b059a01) into main (9b24cf5) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #203      +/-   ##
==========================================
+ Coverage   93.61%   93.62%   +0.01%     
==========================================
  Files          11       11              
  Lines         673      675       +2     
==========================================
+ Hits          630      632       +2     
  Misses         43       43              
Flag Coverage Δ
unittests 93.62% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/test_models.py 95.47% <100.00%> (+0.08%) ⬆️
test/test_models_anchor_utils.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b24cf5...b059a01. Read the comment docs.

@zhiqwang zhiqwang merged commit 5dd25c3 into main Dec 20, 2021
@zhiqwang zhiqwang deleted the cleanup-anchor-generator branch December 20, 2021 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bc-breaking Backwards Incompatible Changes code quality Code format and unit tests enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants