-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow loading of user-trained ultralytics models #79
Conversation
Support loading ultralytics model with custom weights
bugfix for custom yolov5 models.
Update update_module_state.py
allow selective conversion to fp16, ultralytics version other than la…
bugfix, was not returning updated model
Codecov Report
@@ Coverage Diff @@
## master #79 +/- ##
=======================================
Coverage 81.79% 81.79%
=======================================
Files 8 8
Lines 736 736
=======================================
Hits 602 602
Misses 134 134
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dkloving , Thank you for your pull request and welcome to our community.
I have a comment about the parameter naming rule, which could be more user-friendly, let me know your thoughts?
Because of some limitations in my design here, the current parameter configuration is still a bit complicated. For example, when users train their tasks, the |
Hi @dkloving , I've added some commits directly on your branch. It would be better if we could add a unit-test for updating custom model checkpoint trained from ultralytics, but let's merge this PR first for more feedbacks in the future! If you have more questions, fell free to open a new issue or submit a PR about it. And thanks for your contribution here! |
Allows the user to specify a file to use when loading an ultralytics model for conversion. This is valuable for users who have already trained their models using ultralytics and don't wish to re-train.
Optional disabling of fp16 conversion is provided to users because some custom ultralytics models have been observed to not convert entirely to fp16 upon export to onnx, creating invalid onnx model files. Ideally this can be fixed to reliably convert all ultralytics models to fp16.