Revert "Dropped test runs on Python 3.5"

This reverts commit 9b5b1ba.
zhmcclient · May 18, 2024 · a4df549 · a4df549
1 parent b16d6e4
commit a4df549
Show file tree

Hide file tree

Showing 3 changed files with 73 additions and 8 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -35,9 +35,24 @@ jobs:
         if [[ "${{ github.event_name }}" == "schedule" || "${{ github.head_ref }}" =~ ^release_ ]]; then \
           echo "matrix={ \
             \"os\": [ \"ubuntu-latest\", \"macos-latest\" ], \
-            \"python-version\": [ \"3.6\", \"3.7\", \"3.8\", \"3.9\", \"3.10\", \"3.11\", \"3.12\" ], \
+            \"python-version\": [ \"3.5\", \"3.6\", \"3.7\", \"3.8\", \"3.9\", \"3.10\", \"3.11\", \"3.12\" ], \
             \"package_level\": [ \"minimum\", \"latest\", \"ansible\" ], \
             \"exclude\": [ \
+              { \
+                \"os\": \"ubuntu-latest\", \
+                \"python-version\": \"3.5\", \
+                \"package_level\": \"minimum\" \
+              }, \
+              { \
+                \"os\": \"ubuntu-latest\", \
+                \"python-version\": \"3.5\", \
+                \"package_level\": \"latest\" \
+              }, \
+              { \
+                \"os\": \"ubuntu-latest\", \
+                \"python-version\": \"3.5\", \
+                \"package_level\": \"ansible\" \
+              }, \
               { \
                 \"os\": \"ubuntu-latest\", \
                 \"python-version\": \"3.6\", \
@@ -53,6 +68,21 @@ jobs:
                 \"python-version\": \"3.6\", \
                 \"package_level\": \"ansible\" \
               }, \
+              { \
+                \"os\": \"macos-latest\", \
+                \"python-version\": \"3.5\", \
+                \"package_level\": \"minimum\" \
+              }, \
+              { \
+                \"os\": \"macos-latest\", \
+                \"python-version\": \"3.5\", \
+                \"package_level\": \"latest\" \
+              }, \
+              { \
+                \"os\": \"macos-latest\", \
+                \"python-version\": \"3.5\", \
+                \"package_level\": \"ansible\" \
+              }, \
               { \
                 \"os\": \"macos-latest\", \
                 \"python-version\": \"3.6\", \
@@ -103,6 +133,21 @@ jobs:
                 \"package_level\": \"ansible\", \
                 \"container\": {\"image\": \"python:2.7.18-buster\"} \
               }, \
+              { \
+                \"os\": \"ubuntu-20.04\", \
+                \"python-version\": \"3.5\", \
+                \"package_level\": \"minimum\" \
+              }, \
+              { \
+                \"os\": \"ubuntu-20.04\", \
+                \"python-version\": \"3.5\", \
+                \"package_level\": \"latest\" \
+              }, \
+              { \
+                \"os\": \"ubuntu-20.04\", \
+                \"python-version\": \"3.5\", \
+                \"package_level\": \"ansible\" \
+              }, \
               { \
                 \"os\": \"ubuntu-20.04\", \
                 \"python-version\": \"3.6\", \
@@ -118,6 +163,21 @@ jobs:
                 \"python-version\": \"3.6\", \
                 \"package_level\": \"ansible\" \
               }, \
+              { \
+                \"os\": \"macos-12\", \
+                \"python-version\": \"3.5\", \
+                \"package_level\": \"minimum\" \
+              }, \
+              { \
+                \"os\": \"macos-12\", \
+                \"python-version\": \"3.5\", \
+                \"package_level\": \"latest\" \
+              }, \
+              { \
+                \"os\": \"macos-12\", \
+                \"python-version\": \"3.5\", \
+                \"package_level\": \"ansible\" \
+              }, \
               { \
                 \"os\": \"macos-12\", \
                 \"python-version\": \"3.6\", \
@@ -168,6 +228,16 @@ jobs:
                 \"package_level\": \"latest\", \
                 \"container\": {\"image\": \"python:2.7.18-buster\"} \
               }, \
+              { \
+                \"os\": \"ubuntu-20.04\", \
+                \"python-version\": \"3.5\", \
+                \"package_level\": \"minimum\" \
+              }, \
+              { \
+                \"os\": \"ubuntu-20.04\", \
+                \"python-version\": \"3.5\", \
+                \"package_level\": \"latest\" \
+              }, \
               { \
                 \"os\": \"ubuntu-20.04\", \
                 \"python-version\": \"3.6\", \
@@ -205,7 +275,7 @@ jobs:
               }, \
               { \
                 \"os\": \"macos-12\", \
-                \"python-version\": \"3.6\", \
+                \"python-version\": \"3.5\", \
                 \"package_level\": \"latest\" \
               }, \
               { \

diff --git a/docs/source/installation.rst b/docs/source/installation.rst
@@ -274,8 +274,7 @@ Operating systems:
 
 Python versions:
 
-- Python 2.7 to Python 3.8 are supported on a best-can-do basis. The collection
-  is no longer tested on Python 3.5.
+- Python 2.7 to Python 3.8 are supported on a best-can-do basis
 - Python 3.9 and higher are officially supported (depends on the Ansible version used)
 
 Ansible versions:

diff --git a/docs/source/release_notes.rst b/docs/source/release_notes.rst
@@ -33,10 +33,6 @@ Availability: `AutomationHub`_, `Galaxy`_, `GitHub`_
 
 **Deprecations:**
 
-* This collection is no longer tested on Python 3.5, and its use on Python 3.5
-  is at your own risk. The reason is that the setup of Python 3.5 on Github
-  Actions currently fails.
-
 **Bug fixes:**
 
 * Fixed safety issues up to 2024-05-14.