Use prometheus-client 0.19.0 with official HTTPS/mTLS support #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-maier
force-pushed
the
andy/use-prometheus-client-0.19.0
branch
2 times, most recently
from
1702565 to
40f5199
Compare
Details: * Used the officially released version 0.19.0 of the prometheus-client package and enabled Python versions 3.6 and 3.7 again. * Fixed pylint issue on Python 3.6 and 3.7 where it complains about the new arguments of start_http_server(). The code checks that they are used only on Python 3.8 or higher, where we have the new version of the prometheus-client package. * Fixed a dependency issue with pip on Python 3.l6 and 3.7 that came in while these Python versions were disabled. * Added Python 3.7/3.8 to normal test envs since that is the boundary where HTTPS support got introduced. Signed-off-by: Andreas Maier <maiera@de.ibm.com>
andy-maier
force-pushed
the
andy/use-prometheus-client-0.19.0
branch
from
40f5199 to
cee77d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No review needed.