Support range filters for csv reports (opensearch-project#185)

zhongnansu · Oct 27, 2021 · 988db2a · 988db2a
1 parent 47bafac
commit 988db2a
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 11 deletions.
diff --git a/kibana-reports/package.json b/kibana-reports/package.json
@@ -102,7 +102,6 @@
     "prettier": "2.0.5",
     "react-test-renderer": "^16.13.1",
     "ts-jest": "^26.1.0",
-    "tsc": "^1.20150623.0",
     "typescript": "^3.9.5"
   }
 }
diff --git a/kibana-reports/public/components/context_menu/context_menu_helpers.js b/kibana-reports/public/components/context_menu/context_menu_helpers.js
@@ -129,11 +129,15 @@ export const replaceQueryURL = (pageUrl) => {
   let [, fromDateStringMatch, toDateStringMatch] = queryUrl.match(
     timeRangeMatcher
   );
-  fromDateString = decodeURIComponent(fromDateStringMatch.replace(/[']+/g, ''));
+  const fromDateString = decodeURIComponent(
+    fromDateStringMatch.replace(/[']+/g, '')
+  );
 
   // convert time range to from date format in case time range is relative
   const fromDateFormat = dateMath.parse(fromDateString);
-  toDateString = decodeURIComponent(toDateStringMatch.replace(/[']+/g, ''));
+  const toDateString = decodeURIComponent(
+    toDateStringMatch.replace(/[']+/g, '')
+  );
   const toDateFormat = dateMath.parse(toDateString, { roundUp: true });
 
   // replace to and from dates with absolute date

diff --git a/kibana-reports/server/routes/utils/dataReportHelpers.ts b/kibana-reports/server/routes/utils/dataReportHelpers.ts
@@ -13,12 +13,11 @@
  * permissions and limitations under the License.
  */
 
-import { DATA_REPORT_CONFIG } from './constants';
-
 import esb, { Sort } from 'elastic-builder';
-import moment from 'moment';
 import converter from 'json-2-csv';
 import _ from 'lodash';
+import moment from 'moment';
+import { DATA_REPORT_CONFIG } from './constants';
 
 export var metaData = {
   saved_search_id: <string>null,
@@ -81,6 +80,14 @@ export const buildQuery = (report, is_count) => {
               }
               requestBody.minimumShouldMatch(1);
               break;
+            case 'range':
+              const builder = esb.rangeQuery(item.meta.key);
+              if (item.meta.params.gte) builder.gte(item.meta.params.gte);
+              if (item.meta.params.lte) builder.lte(item.meta.params.lte);
+              if (item.meta.params.gt) builder.gt(item.meta.params.gt);
+              if (item.meta.params.lt) builder.lt(item.meta.params.lt);
+              requestBody.must(builder);
+              break;
           }
           break;
         case true:
@@ -106,6 +113,14 @@ export const buildQuery = (report, is_count) => {
               }
               requestBody.minimumShouldMatch(1);
               break;
+            case 'range':
+              const builder = esb.rangeQuery(item.meta.key);
+              if (item.meta.params.gte) builder.gte(item.meta.params.gte);
+              if (item.meta.params.lte) builder.lte(item.meta.params.lte);
+              if (item.meta.params.gt) builder.gt(item.meta.params.gt);
+              if (item.meta.params.lt) builder.lt(item.meta.params.lt);
+              requestBody.mustNot(builder);
+              break;
           }
           break;
       }

diff --git a/kibana-reports/yarn.lock b/kibana-reports/yarn.lock
@@ -9810,11 +9810,6 @@ ts-jest@^26.1.0:
     semver "7.x"
     yargs-parser "20.x"
 
-tsc@^1.20150623.0:
-  version "1.20150623.0"
-  resolved "https://registry.yarnpkg.com/tsc/-/tsc-1.20150623.0.tgz#4ebc3c774e169148cbc768a7342533f082c7a6e5"
-  integrity sha1-Trw8d04WkUjLx2inNCUz8ILHpuU=
-
 tsconfig-paths@^3.9.0:
   version "3.9.0"
   resolved "https://registry.yarnpkg.com/tsconfig-paths/-/tsconfig-paths-3.9.0.tgz#098547a6c4448807e8fcb8eae081064ee9a3c90b"