Avoid creating an unbound number of atoms when deserializing #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have not checked that this does not break anything. The change assumes that * the structs have all been loaded (which is probably safe to assume) and so the atoms for the field names are already there * the subsequent parsing ignores keys which do not equal an expected struct field name (Probably true in all cases) * the Jason version that Nadia depends on supports the option used (did not check) This could in theory use `Jason.decode!(body keys: :atoms!)` but that would crash when TG adds a field. The code as-is is only secure when talking to a trusted endpoint. Since the endpoint is configurable, this PR should improve security.
|
Sorry for the incomplete fix and the whitespace diff. Hastily opened this via the GH edit function... |
|
Hi, @schnittchen Can you help me with it? please open PR here: |
|
I've abandoned Nadia for https://github.com/schnittchen/cablegram |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have not checked that this does not break anything. The change assumes that
This could in theory use
Jason.decode!(body keys: :atoms!)but that would crash when TG adds a field.The code as-is is only secure when talking to a trusted endpoint. Using an untrusted endpoint exposes the user of the library to a potential DDOS attack by exhausting VM memory.
Since the endpoint is configurable, this PR should improve security. Additionally, users might be tempted to wire webhook payload parsing through the existing code, which would expose a security risk over the webhook endpoint.