Update filament_change_gcode to include upstream changes #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jira: none Change-Id: I6340cb8aa8b2fff174859d796ebf8a36effae004
1. add rectilinear interface pattern for organic support
jira: STUDIO-7181
2. add tree support optgroup
Change-Id: I94882bc34a61c6adc06b8ecbc9f2323f9b039aac
(cherry picked from commit a8142ab3f37e0bd140a31a7e635b8475f471d7e3)
1. do not add interface for small overhangs so supports are easier to remove 2. calculate avoidance more accurately using real layer height jira: STUDIO-6285 3. hybrid nodes won't collide with lower layers 4. calculate max move more accurately 5. do not increase radius if next layer has collision jira: STUDIO-2296, STUDIO-7883 6. rewrite plan_layer_heights to prevent support layers overlap. Now the tree support layers are completely independent to object layers. 6. increase collision areas for interface. The top layers may be too close to interface with adaptive layer heights and very small overhang angle Change-Id: I052c3f66e68afb7663e2d70c846dd09ed7086071 (cherry picked from commit aca511caebfdeec270d4fc0ec6bbbadde77cddc9)
github: 4673 Change-Id: I260b48e833f47383c582f813d979a4fdc2926dd2
Change-Id: I502c82d8f6e9481cadedca4e830cd4545e67f21f jira:none
jira: new Change-Id: I253018cf93d8379de1eaff146420103c0d876e16
jira: new Change-Id: I333af9376d952b2607ee87ebb87f6a6b24462111
Change-Id: I587d656e20ed2ee8927ca2f5272ad715bed66740
jira: github 4715 Change-Id: I6a305395661b3490867ff91d19e2a8e869b73191
Change-Id: Ie53546927d87259897fd2b0d5348404dbf47b4cf Signed-off-by: xun.zhang <xun.zhang@bambulab.com>
jira: STUDIO-7401 1.support select meshboolean target from object list 2.other improvements Change-Id: I81cc914e412e622871930974ac65be9fd8bc36e1
jira:[connect printer] Change-Id: Ifdc25651f4effde8e2a2d2a4e690aa20e0ef7022
jira: STUDIO-5985
most of code from OrcaSlicer,thanks for OrcaSlicer and enricoturri1966
commit 28d0147d0988917a8b9d85441b8836453e0f222e
Author: enricoturri1966 <enricoturri@seznam.cz>
Date: Fri Oct 20 15:41:26 2023 +0800
Introduction of classes ColorRGB and ColorRGBA to unify color data definition and manipulation
Change-Id: I94ff38d9a03b4b91183b150617d6407a8ffa279e
Change-Id: I72e140de35d06308f8aa45f4254e049a83abc432
jira: none Change-Id: I3d5888480ad033953a597a6f74b0b9c8ac47795e (cherry picked from commit 7fa3cb3d6224bab6ef6d8ad75446ed1b460afd4e)
jira: none Change-Id: I797082987378f53480eacdc6a2528cfdedf50528 (cherry picked from commit 654db45bc293c03ec72cbbb7f4a651a7e946f9ea)
jira: STUDIO-7814 Change-Id: I0dc2da305b5a4c83b8f27bd07478b2f8fddebac0 (cherry picked from commit 625336509444cb5ea7640d64b260ede738887941)
Previously painting support enforces on vertical faces doesn't work, as projecting the facets downwards will give empty polygons. Now we use a different mechanism to enable vertical paint-on enforces, by directly adding contact nodes. Note: this feature only works with tree support as only tree support has contact nodes. jira: none Change-Id: Id171b1665566d142a6427285baccb40c0aa00949 (cherry picked from commit 9c882f61eb37350a4486df58de48f0ae489f2d15)
jira: STUDIO-7828 Change-Id: I7a42ab65f260b983b8ea1653e3e23b3eab8c15fd (cherry picked from commit 8f5a5f0dde012f51ce2c3d8997df4bf808ad216a)
jira: none Change-Id: I620e095740c60a8c9d4ceb33d6b3a44ab3d17f05 (cherry picked from commit f71b0fdeee18e3fb1482fa3e5f1121d33724b1a7)
jira: STUDIO-7886 Change-Id: I8e439e26ca9de179726b053291ff029ef4b1dd41 (cherry picked from commit aaa46831a79f309b1775300bb0b6ce4060d27b7c)
when show non_manifold_edges jira: none Change-Id: I9bb3e731715eb595c84e01acd0af86b5600618be (cherry picked from commit 6f56123a42a0837ddf5dbd7f12453899f6a2bcb2)
jira: STUDIO-7953 Change-Id: Ic7cc3efbbd160e3c3b4eddac145f2eb70491b614 (cherry picked from commit 5f7416a8ddd6fe850f7255cb3f5847daedc70113)
JIRA: none Change-Id: I73530d1fef564bb65f24678682d7055cb0741741
JIRA: none Change-Id: I70b5e8586332df9892687ae165212aca9e5e3427
JIRA: none Change-Id: I7f1eff610386b50f7480dd0bf1590f56d5a74cb7
jira: STUDIO-6645 Change-Id: I57e62b824e3faadf9fae1294ef329456055893d0 (cherry picked from commit a678094ffa3d6b8b7900f3e3cac0d3f18fed9f30)
jira: STUDIO-7975 Change-Id: Ic580d298568fc6eab8b1a2c017fa182869b432bf (cherry picked from commit 82bcb099e139065cc00c133f507e955d9955b2f4)
this function crashes if there are empty elements in entities. jira: STUDIO-7975 Change-Id: I0dbeb6b1151dd089be7617ebc3271691f64ac61e (cherry picked from commit df30728617a89891c68e36cce771fb6380355b82)
jira: STUDIO-7405 Change-Id: I0a100746b2845bba57f57e8f6962eca1dbd562aa (cherry picked from commit cbba4177361d8dce1ee09a1bfc39528292d72682)
Change-Id: Iaa2f99111dd5f7228b7b25e1be0a8cbdbfe982a6 Jira: STUDIO-8422
JIRA: none Change-Id: Ife798be7ace480dbda2244b158dcb82edc377fb5
Change-Id: I788fe7504b8b6dad8baedd6f0c813a41cc759b79
jira: 8271 Change-Id: I34bf3e3ba589fc3aead96d74f24de6720a4afd32
jira: STUDIO-8383 Change-Id: I7e83d19768be754ef79f0063d76624358bba5102
jira:8371 Signed-off-by: xun.zhang <xun.zhang@bambulab.com> Change-Id: If51ecd6cb6299bcb42ffbcea1f8b2f2bfc511460
jira:NONE Signed-off-by: xun.zhang <xun.zhang@bambulab.com> Change-Id: If5c872777a789273e8d9857117fba51a48641475
jira:[edit filament] Change-Id: I7e2b4fabeb3930f34fc252f1334e168e4f623b77
Change-Id: Ie5c231f55fcaaeee6ac635372ed2dea9906b8850
(plane_normal.dot(ray_dir)) jira:STUDIO-8274 Change-Id: Ib3145ab75e18c832d20065d204aa41b75f73b673
JIRA: STUDIO-8263 Change-Id: If44c5f2cf52e77fea0f1967d071a442fff5ee5b6 Signed-off-by: Stone Li <stone.li@bambulab.com>
Use support_islands for all types of suports to avoid gaps between support regions of the first layer. jira: STUDIO-8443 Change-Id: Ic65b47640d8352d406bb11eeff7390532631712b
Jira: none Signed-off-by: qing.zhang <qing.zhang@bambulab.com> Change-Id: I91951fb4af92615bc5b3d04f04b561f9074cedc1
Jira: 8369 Change-Id: I33e5efbb5af2a35cd20ba009c14441c5bc2ccf48
Change-Id: Iae22c6e6c9fc51755c9deb5d266f2794001b24a0
jira: no-jira Change-Id: Icb2da53911430ac144b0fb601637a7ad31e7e8db
Change-Id: I63fd26e79175fea17aff61e1b99414457815b46d
Change-Id: I7188108062ad8a4cc8cfebb14563d894ccae882b
Change-Id: Ie46d75d7dacce96d58ba16e6d328cbf57892db68
1) exploys in brimMap are not modified 2) the overlap judgment is processed in paralleling jira: STUDIO-8443 Change-Id: I8638071cfc06776975034f39aa994fc4dc7ae1be
Change-Id: Ibef15b6751b99486b0a60e4fb9652955666c0d3b
Change-Id: I85432494b2e9a27dc97a1bb464f9f3b04bf5bc2f
Change-Id: I1ce9b0a1b641b157bb2b4710e4d0a9989b697d4d
|
@tsmith35 thank you for your work. I will accept this PR as soon as we have a decision in bambulab#4848, since Bambu suggests this is not the right approach. |
ziehmon
changed the title
|
I edited the PR title to be more intuitively to understand, hope that's okay for you :) |
|
I wiped my fork to clean it up, but I'll resubmit a clean version shortly.
Life has been helter-skelter since my dad passed. If it wasn't for him, I'd
probably be an over-the-road truck driver instead of an ME/controls
engineer. lol
Tom
…On Thu, Oct 17, 2024 at 3:57 PM Simon ***@***.***> wrote:
@tsmith35 <https://github.com/tsmith35> thank you for your work. I will
accept this PR as soon as we have a decision in bambulab#4848
<bambulab#4848>, since Bambu suggests
this is not the right approach.
—
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB2UJVJF32FU7KYAQ3YL6QTZ4AQFLAVCNFSM6AAAAABP3MJL22VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRQGU3DANRQGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
My sincere condolences Tom. Take your time, all the best to you and your family. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ziehmon I cleaned up the two A1-series 0.4 nozzle json machine files to get rid excess \n newline chars. I added an additional "wipe and shake" movement to the A1 json (to match the mini) and added your "move to safe pos" changes.
The rest of the changes are due to BambuStudio main branch commits made since you created your edits. If everything looks okay, I can test out just the json changes. I have an A1 combo and an A1 mini combo, so making the json changes should be a straightforward first step to allow your spiral lift changes to be applied safely.