Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix CI for macos-latest #60

Merged
merged 4 commits into from
May 14, 2024
Merged

feat: fix CI for macos-latest #60

merged 4 commits into from
May 14, 2024

Conversation

chenrui333
Copy link
Contributor

@chenrui333 chenrui333 commented May 13, 2024

fix CI pipeline failures, seeing:

/Users/runner/work/_temp/b78b4be8-0b82-444d-b150-be4b53a8afc4.sh: line 19: initdb: command not found

relates to ikalnytskyi/action-setup-postgres#29

Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333 chenrui333 changed the title chore: bump ikalnytskyi/action-setup-postgres to v6 chore: bump ikalnytskyi/action-setup-postgres to v6 May 13, 2024
@chenrui333 chenrui333 requested a review from jiacai2050 May 13, 2024 12:52
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
@jiacai2050
Copy link
Member

看上游issue ,14不是已经支持了吗?

@chenrui333
Copy link
Contributor Author

chenrui333 commented May 13, 2024

14, 13 都支持 I will followup on that (我等会把 pipeline split 一下)

@chenrui333 chenrui333 changed the title chore: bump ikalnytskyi/action-setup-postgres to v6 feat: fix CI for macos-latest May 14, 2024
Signed-off-by: Rui Chen <rui@chenrui.dev>

fix build

Signed-off-by: Rui Chen <rui@chenrui.dev>
run: |
pkg-config --libs --cflags libpq mysqlclient
zig fmt --check src/
zig build -Dtarget=aarch64-macos
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

本地没什么可以不用加? 如果有上下文可以放这里

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要加 target 是错的

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我准备 followup pr 把这个 pipeline split 一下

@jiacai2050 jiacai2050 merged commit 141ec12 into main May 14, 2024
4 checks passed
@jiacai2050 jiacai2050 deleted the fix-ci branch May 14, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants