-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make_wheels: implement PEP 517 #1
Conversation
Make make_wheels.py a Python build backend, as defined in PEP 517, allowing this project to be pip-installable from source.
I'd probably wait for pypa/packaging#446. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat! I didn't realize something like this is possible.
I have to ask though--is this something we want? I'm not sure what the use case of installing from source here would be. An obvious one is to let end users to install e.g. nightly builds, or for platforms that don't have wheels uploaded on PyPI, but this isn't actually implemented, and it would complicate things quite a lot to do so.
Ultimately make_wheels.py
is a bit of a hack with a singular purpose: to get reproducible binary wheels on PyPI. I appreciate the work you've put into this PR but I ultimately feel like it's out of scope.
I understand your sentiment. The main benefit would be that the project would be installable via pip when the Ultimately, it's up to you. I don't really think the code this PR introduces is that much, it's mostly |
One reason this might not be a good idea is that we're using Also--unless I'm missing something, does the sdist not explicitly specify the dependency on either |
Overall, I feel like building wheels through PEP517 is a nice idea (even if I personally may not see much use of it), but I'm not convinced at all that I want to upload sdists that rely on internal |
Oh, I didn't notice.
I forgot to commit the
Makes sense. We could ship a sdist with all the required artifacts, but that doesn't seem great. Anyway, I totally forgot to generate the metadata for the sdist anyway, so this PR would require a bit more complexity. Closing this as out-of scope for now, if in the future we want to make this work with nightly builds or similar, it could be revisited if it makes sense. |
Make make_wheels.py a Python build backend, as defined in PEP 517,
allowing this project to be pip-installable from source.