-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow specifying the alignment of extern structs #13009
Comments
To clarify, this would specify the default alignment of every field within the struct? Somewhat related, esp. regarding syntax: #8643 |
Yes, that's basically what it does. It's like applying that same alignment manually to every field in the struct. |
This commit adds special cases for AccelerationStructureInstanceKHR and VkAccelerationStructureSRTMotionInstanceNV. These types use bit-packed fields which are not representable in the current version of the zig stage 2 compiler. This might change when ziglang/zig#13009 is resolved. Fixes #56
I wouldn't expect that from the syntax: i would expect it to be the minimum alignment for the entire struct (i.e. the first field of the struct) |
This is a follow-up to #10113: #10113 (comment)
We need an addition to the language that allows us to specify the alignment of
extern struct
s.The UEFI libs are particularly broken because since #10113 any packed struct with an array or any extern struct in it isn't a valid packed type.
In order to make
std.os.uefi
work with self-hosted, #12899 was an effort to make it easier to addalign(1)
to every field of a struct. The problem is that it might not work that well considering that structs with decls can't be reified because of #6709.But instead of allowing #6709 (which might be a bad idea) and then using
CPacked
, it's probably best to allow specifying the alignment ofextern struct
s at the language level.A good syntax for this would be
extern struct align(alignment) {}
.See also: #12745 #12897 #12993
CC @fifty-six
The text was updated successfully, but these errors were encountered: