Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tier 1 support for 32 bit windows (i386-windows target) #537

Open
3 of 7 tasks
andrewrk opened this issue Oct 15, 2017 · 6 comments
Open
3 of 7 tasks

Tier 1 support for 32 bit windows (i386-windows target) #537

andrewrk opened this issue Oct 15, 2017 · 6 comments
Labels
arch-x86 32-bit x86 contributor friendly This issue is limited in scope and/or knowledge of Zig internals. enhancement Solving this issue will likely involve adding new logic or components to the codebase. os-windows standard library This issue involves writing Zig code for the standard library. tier system Issues that track the support tier for a platform.
Milestone
0.14.0

Comments

@andrewrk
Copy link
Member

andrewrk commented Oct 15, 2017 •
edited
Loading

The only thing left is bug fixes:
@andrewrk andrewrk added bug Observed behavior contradicts documented or intended behavior os-windows labels Oct 15, 2017
@andrewrk andrewrk added this to the 0.2.0 milestone Oct 15, 2017
andrewrk added a commit that referenced this issue Oct 15, 2017
@andrewrk
disable some of the failing tests
6fe1c31 
See #537
@andrewrk
Copy link
Member Author

This is effectively blocked by #516 (debug symbols don't work on windows)

@andrewrk andrewrk modified the milestone: 0.2.0 Oct 19, 2017
andrewrk added a commit that referenced this issue Nov 10, 2017
@andrewrk
disable broken 32 bit windows test
1403748 
See #537
andrewrk added a commit that referenced this issue Dec 12, 2017
@andrewrk
self-hosted: workaround for issue #537
a3a590a
andrewrk added a commit that referenced this issue Dec 15, 2017
@andrewrk
disable sort tests for 32-bit windows because of issue #537
6bc0561
andrewrk added a commit that referenced this issue Dec 22, 2017
@andrewrk
std.math: remove unnecessary inline calls and
e44a113 
workaround windows 32 bit test failure
See #537
@andrewrk andrewrk mentioned this issue Jan 13, 2018
Merged
andrewrk added a commit that referenced this issue Jan 14, 2018
@andrewrk
remove 32-bit windows from supported targets list
793f031 
we still want to support it, but there are too many bugs
to claim that we support it right now.

See #537
@andrewrk andrewrk added enhancement Solving this issue will likely involve adding new logic or components to the codebase. and removed bug Observed behavior contradicts documented or intended behavior labels Jan 14, 2018
@andrewrk
Copy link
Member Author

I removed 32 bit windows from the supported target list, because we had too many failing tests to justify it.

We still want to support it in a future release, but there's some debugging to be done.

cc @tiehuis

@andrewrk andrewrk changed the title failing tests on i386-windows target support 32 bit windows (i386-windows target) Jan 14, 2018
@andrewrk andrewrk modified the milestones: 0.2.0, 0.3.0 Jan 14, 2018
@andrewrk andrewrk modified the milestones: 0.3.0, 0.4.0 Feb 28, 2018
@andrewrk andrewrk modified the milestones: 0.4.0, 0.5.0 Feb 2, 2019
@andrewrk andrewrk changed the title support 32 bit windows (i386-windows target) Tier 1 support for 32 bit windows (i386-windows target) Feb 7, 2019
@andrewrk andrewrk added arch-x86 32-bit x86 standard library This issue involves writing Zig code for the standard library. contributor friendly This issue is limited in scope and/or knowledge of Zig internals. stage1 The process of building from source via WebAssembly and the C backend. labels Feb 7, 2019
@ljmccarthy
Copy link

ljmccarthy commented Apr 9, 2019 •
edited
Loading

I recently tried building for this target and got a load of assembler syntax errors.

> zig build-exe -target i386-windows-msvc test.zig
<inline asm>:5:44: error: unknown token in expression
         mov         eax,dword ptr [esp+18h]
                                           ^
<inline asm>:8:44: error: unknown token in expression
         mov         ecx,dword ptr [esp+14h]
                                           ^
<inline asm>:9:44: error: unknown token in expression
         mov         eax,dword ptr [esp+10h]
                                           ^
...
LLVM ERROR: Error parsing inline asm

@tgschultz tgschultz mentioned this issue Apr 11, 2019
Closed
@emekoi
Copy link
Contributor

emekoi commented Jul 30, 2019

@andrewrk do you know what could be causing zig to emit this assembly?
related: https://reviews.llvm.org/D59810

@emekoi emekoi mentioned this issue Aug 3, 2019
Closed
@andrewrk andrewrk modified the milestones: 0.5.0, 0.6.0 Aug 27, 2019
@LemonBoy LemonBoy mentioned this issue Oct 6, 2019
Merged
@andrewrk andrewrk modified the milestones: 0.6.0, 0.7.0 Oct 23, 2019
@andrewrk andrewrk modified the milestones: 0.7.0, 0.8.0 Oct 9, 2020
@andrewrk andrewrk modified the milestones: 0.8.0, 0.9.0 Nov 6, 2020
@andrewrk andrewrk modified the milestones: 0.9.0, 0.10.0 May 19, 2021
@Prince213 Prince213 mentioned this issue Oct 15, 2021
Closed
@messense messense mentioned this issue Sep 14, 2022
Closed
messense added a commit to rust-cross/cargo-zigbuild that referenced this issue Sep 14, 2022
@messense
Don't test i686-pc-windows-gnu on CI
1e6e091 
It's broken ziglang/zig#537
@andrewrk andrewrk removed the stage1 The process of building from source via WebAssembly and the C backend. label Dec 7, 2022
@andrewrk andrewrk modified the milestones: 0.14.0, 0.11.0 Aug 3, 2023
@andrewrk
Copy link
Member Author

andrewrk commented Aug 3, 2023

32-bit windows is back to tier 1 status :-)

@andrewrk andrewrk closed this as completed Aug 3, 2023
@andrewrk
Copy link
Member Author

andrewrk commented Aug 3, 2023

Never mind, there are blocking bugs. Updated the description.

@andrewrk andrewrk reopened this Aug 3, 2023
@andrewrk andrewrk modified the milestones: 0.11.0, 0.12.0 Aug 3, 2023
@agriyakhetarpal agriyakhetarpal mentioned this issue Apr 24, 2024
Closed
@alexrp alexrp mentioned this issue Jun 22, 2024
Open
@MeerMusik MeerMusik mentioned this issue Aug 23, 2024
Closed
@alexrp alexrp added the tier system Issues that track the support tier for a platform. label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arch-x86 32-bit x86 contributor friendly This issue is limited in scope and/or knowledge of Zig internals. enhancement Solving this issue will likely involve adding new logic or components to the codebase. os-windows standard library This issue involves writing Zig code for the standard library. tier system Issues that track the support tier for a platform.
Projects
None yet
Milestone
0.14.0
Development

No branches or pull requests
4 participants
@alexrp @andrewrk @ljmccarthy @emekoi