-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add arm-features.h from glibc source #12346
Conversation
May be close #3287 |
missing 1. test coverage (see test/standalone), 2. CI qemu fixup, and (but very unsure) 3. brief clarification/ensuring that this does not mess up the glibc update routine. |
This is simple header file - what need test?
Workaround - manually add this header file. After this - build success. |
arm gnu crosscompiling + running needs tests in CI. Sorry, I have not been explicit from the beginning. See #3174 |
I can verify that this works and builds working executables. Going back through older releases of zig, I could not find a version that includes a glibc that can build 32-bit arm binaries. |
Thank you! Not sure why that file had been forgotten, but its addition indeed allows Thanks! |
This is missing CI coverage: "Is there more to this than just merging #12346?" |
arm-linux is still Tier 2 "These targets are known to work, but may not be automatically tested". |
It's included in zig now, see ziglang/zig#12346
Problems with -target arm-linux-gnueabi
zig build-exe hello.c -target arm-linux-gnueabi --library c --verbose-cc --name hello-zig ... In file included from /usr/local/Cellar/zig/0.9.1_1/lib/zig/libc/glibc/sysdeps/unix/sysv/linux/arm/sysdep.h:25: In file included from /usr/local/Cellar/zig/0.9.1_1/lib/zig/libc/glibc/sysdeps/unix/arm/sysdep.h:19: /usr/local/Cellar/zig/0.9.1_1/lib/zig/libc/glibc/sysdeps/arm/sysdep.h:25:11: fatal error: 'arm-features.h' file not found ...
Add file arm-features.h from the glibc source.