-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
std: valgrind client request support for aarch64 #13292
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Matches what I see in valgrind.h.
Nice! I'd like to do the corresponding improvements to src/target.zig and src/codegen/llvm.zig ( |
Ah, sorry for not seeing that. Target is easy but I'm not comfortable with the llvm side. I'll sit tight... no rush this is obviously not critical. |
This also modifies the inline assembly to be more optimizable - instead of doing explicit movs, we instead communicate to LLVM which registers we would like to, somehow, have the correct values. This is how the x86_64 code already worked and thus allows the code to be unified across the two architectures. As a bonus, I threw in x86 support.
eeeef01
to
78389af
Compare
This is now done, but I was unable to test it on aarch64 due to #10086 (which I will be looking into shortly) or x86 due to not having an x86 machine lying around. |
Tested on aarch64-linux Debian-bullseye:
Looks like the code here works, although I'm not sure why the debug info is missing. |
Tested locally on my aarch64 machine.