-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
glibc: add backwards compatibility for some symbols #15101
Conversation
9ef4b79
to
a19c669
Compare
Besides the test you added, is there anything else we can do to make the upgrade path easier here. Sounds like a pain to upgrade glibc, then have to debug this failing test and try to slueth out that you need to re-apply this diff. |
Good question. I will make this a bit easier to apply:
|
- `fcntl` was renamed to `fcntl64` in glibc 2.28 (see ziglang#9485) - `res_{,n}{search,query,querydomain}` became "their own" symbols since glibc 2.34: they were prefixed with `__` before. This PR makes it possible to use `fcntl` with glibc 2.27 or older and the `res_*` functions with glibc 2.33 or older. These patches will become redundant with universal-headers and can be dropped. But we have to do with what we have now. Closes ziglang#9485
btw this might be useful https://wiki.gentoo.org/wiki/Project:Toolchain/Porting_notes#glibc |
Hello, it's me from the future. It's no problem at all since the documented process tells you to run |
fcntl
was renamed tofcntl64
in glibc 2.28 (see glibc 2.27 or older: fcntl64 not found, but zig's glibc headers refer it #9485)res_{,n}{search,query,querydomain}
became "their own" symbols since glibc 2.34: they were prefixed with__
before.This PR makes it possible to use
fcntl
with glibc 2.27 or older and theres_*
functions with glibc 2.33 or older.These patches will become redundant with universal-headers and can be dropped. But we have to do with what we have now.
Closes #9485
Related: 39083c3