Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move rpath to frontend and remove native paths from it #17917

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

Jan200101
Copy link
Contributor

@Jan200101 Jan200101 commented Nov 7, 2023

As discussed at compiler meeting 2023-10-26.

Needed tests:

  • system deps
  • NixOS
  • local deps

@Jan200101 Jan200101 marked this pull request as ready for review November 9, 2023 07:11
@andrewrk
Copy link
Member

andrewrk commented Jan 14, 2024

This had conflicts with master branch, but it had already passed the CI before that, so I rebased it on your behalf.

I also dropped these commits from it:

I don't think the build script should be doing those things. Let's discuss those changes in a follow-up if you still want to pursue those.

One more thing: With just that NativePaths one-line change you made, it looks like it might be possible to change the default of each-lib-rpath to be off, or even have that option removed altogether.

@kubkon kubkon merged commit 852e7e2 into ziglang:master Jan 15, 2024
10 checks passed
@Jan200101
Copy link
Contributor Author

This had conflicts with master branch, but it had already passed the CI before that, so I rebased it on your behalf.

Thanks

I also dropped these commits from it:

* [f306d2a](https://github.com/ziglang/zig/commit/f306d2acdaefbf2db82c018e58a3dfbf49d321d2)

* [d4328e4](https://github.com/ziglang/zig/commit/d4328e42f4c4eede8ef93125ea1a59890b71d2c6)

I don't think the build script should be doing those things. Let's discuss those changes in a follow-up if you still want to pursue those.

These were mainly there to simplify testing the result of all the different environments without changing the overall behavior of Zig...

One more thing: With just that NativePaths one-line change you made, it looks like it might be possible to change the default of each-lib-rpath to be off, or even have that option removed altogether.

It should be able to cover NixOS and systemwide libraries, but I am unsure if it would cover user libraries. Will need to do testing before that proposal can be made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants