Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compiler-rt: add aeabi_dcmp, comparedf2 #2342

Merged
merged 1 commit into from
Apr 25, 2019
Merged

compiler-rt: add aeabi_dcmp, comparedf2 #2342

merged 1 commit into from
Apr 25, 2019

Conversation

justinbalexander
Copy link
Contributor

No description provided.

@andrewrk
Copy link
Member

I think the test isn't getting run, because it's never imported. Can you double check the test is getting run? I think that applies to #2299 as well.

@justinbalexander
Copy link
Contributor Author

justinbalexander commented Apr 24, 2019 via email

@justinbalexander
Copy link
Contributor Author

Done.

@justinbalexander
Copy link
Contributor Author

I rebased and force-pushed. Is that a good workflow for changes to a pull request?

@andrewrk
Copy link
Member

andrewrk commented Apr 24, 2019 •
edited
Loading

I rebased and force-pushed. Is that a good workflow for changes to a pull request?

Yep. Thanks!

@andrewrk andrewrk merged commit 01168e1 into ziglang:master Apr 25, 2019
@justinbalexander justinbalexander deleted the dcmp branch April 25, 2019 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justinbalexander @andrewrk