openbsd: skip tests using Dir.realpath #7071
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Dir.realpath()
implementation is based ongetFdPath()
, which doesn't exist on OpenBSD (or some others OS like FreeBSD). Disable the tests using it for now.I am thinking about some ways to provide alternative implementation, for example:
realpath()
; but not all descriptors are opened with a name: on exec you could have an already open descriptor, or you could receive descriptor from UNIX socketopenat(fd, "..")
and searching for the right inode withfstat()
) ; but it could be permission issue to read directory contentchdir()
on the descriptor and read the path withgetcwd()
; but it is bad when threads are involved (it changes a global parameter)I will see that later.