translate-c: allow string literals to be used as char *
#9554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Question: is this a valid Zig construct (this is how I'm translating the C global variable pub export var s: [*c]u8 = blk: {
var string_temp: @TypeOf("my_string".*) = "my_string".*;
break :blk &string_temp;
}; |
It is now but won't be after #7396. If you put the var inside a struct it should be good. |
|
So something like this (possibly with an intermediate variable to hold the struct depending on what is easier to do with existing translate-c constructs): pub export var s: [*c]u8 = blk: {
break :blk &struct {
var string_temp: @TypeOf("my_string".*) = "my_string".*;
}.string_temp;
}; |
Yup, placing it inside a struct gives it static lifetime. |
ehaas
force-pushed
the
translate-c-string-literal
branch
2 times, most recently
from
8e1270b
to
f104d7d
Compare
In C the type of string literals is `char *`, so when using them in a non-const context we have to cast the const away. Fixes ziglang#9126
ehaas
force-pushed
the
translate-c-string-literal
branch
from
f104d7d
to
5a984fd
Compare
ehaas
commented
Aug 20, 2021
src/translate_c.zig
Outdated
| @@ -719,6 +719,30 @@ fn transQualTypeMaybeInitialized(c: *Context, scope: *Scope, qt: clang.QualType, | |||
| transQualType(c, scope, qt, loc); | |||
| } | |||
|
|
|||
| /// This is used in global scope to convert a string literal `S` to [*c]u8: | |||
| /// &(struct { | |||
| /// var static: @TypeOf(S.*) = S.*; | |||
There was a problem hiding this comment.
I don't want to restart the CI builds over a comment but this doc comment is out of date now
Vexu
force-pushed
the
translate-c-string-literal
branch
from
0450cb5
to
236244e
Compare
borgoat
added a commit
to borgoat/er_zig_driver
that referenced
this pull request
Oct 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In C the type of string literals is
char *, so when using them ina non-const context we have to cast the const away.
Fixes #9126