-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Xiaomi H1 alternative signature #2806
Fix Xiaomi H1 alternative signature #2806
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2806 +/- ##
=======================================
Coverage 87.35% 87.35%
=======================================
Files 287 287
Lines 8835 8837 +2
=======================================
+ Hits 7718 7720 +2
Misses 1117 1117 ☔ View full report in Codecov by Sentry. |
Hmm, unless I'm missing something, I don't see where that quirk was removed. Maybe it was using a quirk without I'll have a look. Please also attach device diagnostics and/or the device signature. It can be downloaded from the device page. |
Looks like it matches the zha-device-handlers/zhaquirks/xiaomi/aqara/opple_switch.py Lines 277 to 281 in aeca76d
So, |
Okay, it seems like (at least the US models of) Aqara switches sometimes report a different signature when paired. This might explain some things. I'll fix #2824 first and then see how many signatures also match the H1 models. |
Superseded by #2826 Thanks for making me aware btw! |
Great, thank you! In addition to this, I made some configuration entities for the H1 and was wondering if there was a better way to match all of the devices using a similar configuration, to prevent a HA PR every time a device is added: right now the matching works by using a quirk ID, eg
Could you point me in the right direction for how I could match these configuration entities to catch all devices? |
Proposed change
It seems like this commit kicked a device signature for Xiaomi H1 switches: 4f5abdd
This PR adds it back.
Additional information
Checklist
pre-commit
checks pass / the code has been formatted using Black