Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set manufacturer_id_override to NO_ID for Tuya IR blaster #3865

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

TheJulianJES
Copy link
Collaborator

Proposed change

This forces the Tuya IR blaster to send no manufacturer id, as we generally shouldn't send one for Tuya devices.

Additional information

Detected by:

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

@TheJulianJES TheJulianJES added the Tuya Request/PR regarding a Tuya device label Feb 13, 2025
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.94%. Comparing base (6248323) to head (97a4ac2).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3865   +/-   ##
=======================================
  Coverage   90.93%   90.94%           
=======================================
  Files         326      326           
  Lines       10583    10585    +2     
=======================================
+ Hits         9624     9626    +2     
  Misses        959      959           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheJulianJES TheJulianJES merged commit 1c97fcf into zigpy:dev Feb 13, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tuya Request/PR regarding a Tuya device
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant