Rewrite beast C++ test server #110
Open
+142
−88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This happens to use C++20 coroutines because I'm lazy. It can equivalently be written without. I reworded measure.sh to use cmake instead of zig build. Again, I'm lazy and don't wish to learn zig build today. The flake had dependency issues - for one, the beast archive references in cpp/build.zig.zon is gone; - secondly the upstream zig flake does not have zig 12.0 ¯\_(ツ)_/¯ Luckily that's in Nixpkgs, so I switched to nixpkgs-unstable. - I also added a `liburing` dependency to the devShell. This was to test with uring, but it didn't produce better results
|
I should probably make explicit that I post the PR to make the maintainers of this zigzap project aware of the improved C++ server. Feel free to fix the collateral damage (cmake, measure.sh, Program.cs) which solely exists for practical reasons to test for the linked Beast issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rewrite was prompted by the issue opened on the beast repository: boostorg/beast#2883
You can see the relative timings (there are several choices) there. Suffice it to say that the fast config is 10x faster than the original.
From the commit message:
This happens to use C++20 coroutines because I'm lazy. It can equivalently be written without.
I reworded measure.sh to use cmake instead of zig build. Again, I'm lazy and don't wish to learn zig build today.
The Nix flake had dependency issues
liburingdependency to the devShell. This was only temporary to test with uring, but it didn't produce better results