Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prints the current backup config file in yaml format to stdio #209

Merged
merged 13 commits into from
May 9, 2024

Conversation

roca
Copy link
Contributor

@roca roca commented Sep 22, 2023

/kind improvement

fix #204, fix #128, fix #120

  • Adds the ability to override backup_yaml values using a capitalized snake case format (--set MILVUS_USER=Marco)"
  • Command to print the current backup config file in yaml format to stdout

This is a work in progress

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Sep 22, 2023
@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: roca

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot
Copy link
Collaborator

Welcome @roca! It looks like this is your first PR to zilliztech/milvus-backup 🎉

@mergify
Copy link

mergify bot commented Sep 22, 2023

@roca Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/main/CONTRIBUTING.md#developer-certificate-of-origin-dco.

…nake case format (--set MILVUS_USER=Marco)"

Command to print the current backup config file in yaml format to stdio

Signed-off-by: romel.campbell <romel.campbell@regeneron.com>
@mergify mergify bot removed the ci-passed label Sep 27, 2023
Copy link

mergify bot commented Mar 5, 2024

@roca Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/main/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@wayblink wayblink merged commit d3d81c5 into zilliztech:main May 9, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/improvement Changes related to something improve, likes ut and code refactor needs-dco size/L
Projects
None yet
4 participants