Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command-line parameters for backup MinIO cross-storage #420

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Command-line parameters for backup MinIO cross-storage #420

merged 1 commit into from
Sep 5, 2024

Conversation

MatanAmoyal1
Copy link
Contributor

  • Added command-line parameters for backup MinIO cross-storage.
  • 'initBackupSecretAccessKey': Retrieve the configuration of 'minio.backupSecretAccessKey' first.
  • Changed "string" to "fmt.Sprint" to fix the "go test -v -test.run TestCreateBackup" failure.
  • Swagger: Modified the collection_name parameter in ListBackup to be optional.

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MatanAmoyal1

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot
Copy link
Collaborator

Welcome @MatanAmoyal1! It looks like this is your first PR to zilliztech/milvus-backup 🎉

@mergify Mergify
Copy link

mergify bot commented Sep 4, 2024

@MatanAmoyal1 Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/main/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added the needs-dco label Sep 4, 2024
@mergify Mergify
Copy link

mergify bot commented Sep 4, 2024

@MatanAmoyal1 Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@MatanAmoyal1
adding cmd param for backup minio crossStorage
c94d2c0 
Signed-off-by: mamoyal <matan.amoyal@intel.com>
@mergify mergify bot added dco-passed and removed needs-dco labels Sep 4, 2024
@MatanAmoyal1
Copy link
Contributor Author

issue: #419

@MatanAmoyal1 MatanAmoyal1 mentioned this pull request Sep 4, 2024
Closed
@wayblink wayblink merged commit 8d6fa7a into zilliztech:main Sep 5, 2024
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dco-passed do-not-merge/missing-related-issue size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MatanAmoyal1 @sre-ci-robot @wayblink