Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fractional max_samples #47

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Fix fractional max_samples #47

merged 1 commit into from
Apr 10, 2024

Conversation

reidjohnson
Copy link
Member

Resolves #46.

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.87%. Comparing base (32ddf35) to head (9f38a48).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #47   +/-   ##
=======================================
  Coverage   98.86%   98.87%           
=======================================
  Files           4        4           
  Lines        1058     1062    +4     
=======================================
+ Hits         1046     1050    +4     
  Misses         12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reidjohnson reidjohnson merged commit 05cd3bd into main Apr 10, 2024
32 checks passed
@reidjohnson reidjohnson deleted the dev/fix-max-samples branch April 10, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fractional 'max_samples' Results in Error
1 participant