✨Marketplace: Collect Taxes for Products with a TaxRate on Checkout
#1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zspencer
force-pushed
the
marketplace/collect-taxes
branch
2 times, most recently
from
3113dfc to
5e7c58b
Compare
zspencer
changed the title
Marketplace: Collect Taxes for Products with a TaxRate on CheckoutMarketplace: Collect Taxes for Products with a TaxRate on Checkout
anaulin
approved these changes
Mar 9, 2023
app/furniture/marketplace/cart.rb
Outdated
| def tax_total | ||
| cart_products.sum(0) do |cart_product| | ||
| cart_product.tax_amount | ||
| end |
There was a problem hiding this comment.
Isn't this just cart_products.sum(&:tax_amount) ?
|
|
||
| validates_uniqueness_of :product, scope: :cart_id | ||
| validate :editable_cart | ||
|
|
||
| attribute :quantity, :integer, default: 0 | ||
|
|
||
| def tax_amount | ||
| price_total * (tax_rates.sum(0) do |tax_rate| | ||
| tax_rate.tax_rate |
There was a problem hiding this comment.
Same as above, I think this can be price_total * (tax_rates.sum(&:tax_rate) / 100)
…kout` - #1137 Whoooo! `TaxRate` gets calculated! And collected! Co-authored-by: Ana Ulin <anaulin@users.noreply.github.com> Co-authored-by: Dalton Pruitt <daltonrpruitt@users.noreply.github.com> Co-authored-by: Kelly Hong <KellyAH@users.noreply.github.com>
zspencer
force-pushed
the
marketplace/collect-taxes
branch
from
5e7c58b to
1cc1052
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marketplace:TaxCollection and Compliance #1137Whoooo!
TaxRategets calculated! And collected!tax-rates-demo.mp4