🥔✨ Marketplace: Show Order#tax_amount on Marketplace::Order#show
#1206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zspencer
force-pushed
the
marketplace/show-taxes-collected-on-order
branch
2 times, most recently
from
bae4308 to
94b3fe4
Compare
zspencer
changed the title
Marketplace: Show Tax on OrderMarketplace: Show Tax on Marketplace::Order#show
zspencer
changed the title
Marketplace: Show Tax on Marketplace::Order#showMarketplace: Show Order#tax_amount on Marketplace::Order#show
anaulin
reviewed
Mar 11, 2023
| cart_products.sum(0) do |cart_product| | ||
| cart_product.price_total | ||
| end | ||
| cart_products.sum(0, &:price_total) |
There was a problem hiding this comment.
You don't need that 0. This can just be cart_products.sum(&:price_total)
anaulin
approved these changes
Mar 11, 2023
| end | ||
|
|
||
| def tax_total | ||
| ordered_products.sum(0, &:tax_amount) |
There was a problem hiding this comment.
:: gestures vaguely in the direction of the 0s ::
| end | ||
|
|
||
| delegate :delivery_fee, to: :marketplace | ||
|
|
||
| def price_total | ||
| product_total + delivery_fee | ||
| product_total + delivery_fee + tax_total |
There was a problem hiding this comment.
Smol unit test would be nice. 😊
There was a problem hiding this comment.
no, u get big unit test.
zspencer
force-pushed
the
marketplace/show-taxes-collected-on-order
branch
from
94b3fe4 to
950be2a
Compare
- #1137 The entire `Marketplace::Order` page is potato-tier, but at least it exists!
zspencer
force-pushed
the
marketplace/show-taxes-collected-on-order
branch
from
0029d2e to
773442f
Compare
zspencer
force-pushed
the
marketplace/show-taxes-collected-on-order
branch
from
773442f to
53297b3
Compare
zspencer
added
✨ feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marketplace:TaxCollection and Compliance #1137The entire
Marketplace::Orderpage is potato-tier, but at least it exists!