Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧹🐞🌸 Marketplace: Tidy up Product#index #1337

Merged
merged 9 commits into from
Apr 10, 2023
Merged

🧹🐞🌸 Marketplace: Tidy up Product#index #1337

merged 9 commits into from
Apr 10, 2023

Conversation

zspencer
Copy link
Member

@zspencer zspencer commented Apr 9, 2023 •
edited
Loading

Other Changes:

  • 🐞 Marketplace: Fix broken link on Product#edit page
  • 🌸Marketplace: Product#index is a Grid of Cards
  • 🧹Marketplace: Use ButtonComponent instead of buttons/edit and buttons/new
  • 🧹Components: Remove buttons/edit and buttons/new
  • 🌸Marketplace: TaxRate#show has higher precision

After

Screenshot 2023-04-09 at 3 51 07 PM

Screenshot 2023-04-09 at 3 50 54 PM

Screenshot 2023-04-09 at 3 50 47 PM

Screenshot 2023-04-09 at 3 51 40 PM

Before

@zspencer zspencer requested review from KellyAH, anaulin and a team April 9, 2023 21:30
@zspencer zspencer added 🐞 bug Something isn't working 🧹 refactor Includes non-behavioral changes 🌸 Polish Improves the UX! labels Apr 9, 2023
@zspencer zspencer changed the title 🧹🐞 Marketplace: Fix broken link on Product#edit page 🧹🐞🌸 Marketplace: Tidy up Product#index Apr 9, 2023
@zspencer
Copy link
Member Author

zspencer commented Apr 9, 2023

This should also fit much more nicely with the new management layout @anaulin is working on in #1329

zspencer added 5 commits April 9, 2023 15:19
@zspencer
🧹🐞 Marketplace: Fix broken link on Product#edit page
4225628 
- #1187
- #1324

There is no `Product#show` 🙃

Other Changes:
- 🧹`Marketplace`: Use `ButtonComponent` instead of `buttons/edit`
- 🧹`Components`: Remove `buttons/edit`
@zspencer
🌸Marketplace: Product#index is a Grid of Cards
4dcb048 
- #1324

The table layout was not great on mobile, and this is slightly better.
@zspencer
🧹Components: Inline buttons/new partial
10833a5
@zspencer
🌸Marketplace: Increase shown precision of TaxRate
6dcc36b
@zspencer
🧹 Marketplace: Include better words in the Product#destroy button
9438b51
@zspencer zspencer force-pushed the marketplace/tidy-product-management branch from 4609d17 to 9438b51 Compare April 9, 2023 22:19
zspencer added 4 commits April 9, 2023 15:35
@zspencer
🌸 Marketplace: Products#index is single column on small devices
7865239
@zspencer
🛠️Components: ApplicationComponent supports dom_id
6f8eb1c 
If a `dom_id` is set on the component, it will populate the elements
`id` field with the `dom_id`.

It it's not, but `dom_id` is called with arguments it will delegate that
to `ViewComponent::Base.dom_id`
@zspencer
✨ Marketplace: Products#create shows validation errors
8e82a79
@zspencer
🌸✨ Marketplace: Product#destroy removes elements
dcbda02
anaulin
anaulin approved these changes Apr 10, 2023
View reviewed changes
Copy link
Member

@anaulin anaulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@zspencer zspencer merged commit 37f217b into main Apr 10, 2023
@zspencer zspencer deleted the marketplace/tidy-product-management branch April 10, 2023 01:16
@zspencer zspencer added this to the 1.0 - Andromeda milestone May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anaulin anaulin anaulin approved these changes

@KellyAH KellyAH Awaiting requested review from KellyAH

Assignees
No one assigned
Labels
🐞 bug Something isn't working 🌸 Polish Improves the UX! 🧹 refactor Includes non-behavioral changes
Projects
None yet
Milestone
1.0 - Andromeda
Development

Successfully merging this pull request may close these issues.
2 participants
@zspencer @anaulin