✨🥗 Marketplace: TaxRate actions support Turbo
#1347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zspencer
added a commit
that referenced
this pull request
Apr 11, 2023
- #1347 Pulled out to their own PR
zspencer
force-pushed
the
marketplace/turbo-streamify-tax-rates
branch
from
019a0c1 to
cd4b093
Compare
zspencer
added
✨ feature
anaulin
approved these changes
Apr 11, 2023
zspencer
added a commit
that referenced
this pull request
Apr 11, 2023
* 🌸🥗🛠️✨ `Marketplace`: Tidy up managing `TaxRate`s - #1137 - #1187 OK this is a bit bigger than it probably should be but I came in like a wreeeckiin' ball and: - 🛠️ `Components`: `ApplicationComponent` exposes `policy` and `current_person` - 🛠️ `Components`: Component Specs have `polymorphic_path` - 🥗 `Marketplace`: Tested `TaxRate`, `TaxRateComponent` and `TaxRatesController` - 🌸 `Marketplace`: `TaxRate#edit`, `TaxRate#update`, and `TaxRate#destroy` via TurboStreams - 🌸 `Marketplace`: `TaxRate#index` and `TaxRate#show` are prettier * ✍️ `Marketplace`: Wordsmith `TaxRate#edit` and `TaxRate#destroy` buttons - #1137 This makes it so the text of the button is "Edit" and the label for the button is the fuller text which includes the kind of thing being edited. * `Marketplace`: Drop the controller changes - #1347 Pulled out to their own PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marketplace:TaxCollection and Compliance #1137Marketplace: Tidy up managingTaxRates #1338I don't know why the get actions and passing
asdo not play nicely together, but it is annoying as heck.