Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Marketplace: Add Foreign key for TaxRate#bazaar #1468

Merged

Conversation

zspencer
Copy link
Member

@zspencer zspencer commented May 14, 2023

zspencer added 4 commits May 14, 2023 12:18
- #1137

OK this is a bit larger than I wanted it to be, but it should be a
purely structural change.

- Creates a `Marketplace::Bazaar` class to attach the `TaxRate`
- Migrates `TaxRate` connection to the `Bazaar` on migration
- Maintains the wiring of the `TaxRate` to the `Marketplace`
@zspencer zspencer added the 🧹 refactor Includes non-behavioral changes label May 14, 2023
@zspencer zspencer changed the title Marketplace: Add Foreign key for TaxRate#bazaar 🧹 Marketplace: Add Foreign key for TaxRate#bazaar May 14, 2023
OK, so I *think* this actually wants to be in the same pr that adds
them, just a different migration.
@zspencer zspencer requested a review from a team May 14, 2023 19:57
Base automatically changed from marketplace/tax-rates-are-across-marketplace to main May 16, 2023 22:06
Copy link
Member

@anaulin anaulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗝️

@zspencer zspencer merged commit 3598c2e into main May 17, 2023
@zspencer zspencer deleted the marketplace/add-foreign-key-and-not-null-constraint-to-bazaar-id branch May 17, 2023 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 refactor Includes non-behavioral changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants