Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐞🔨 Gizmo: Fix bug where removing a Gizmo fails #1592

Merged
merged 1 commit into from
Jun 25, 2023
Merged

🐞🔨 Gizmo: Fix bug where removing a Gizmo fails #1592

merged 1 commit into from
Jun 25, 2023

Conversation

zspencer
Copy link
Member

@zspencer zspencer commented Jun 25, 2023 •
edited
Loading

OK this is also a bit much; but it does fix the bug.

Basically, two _methods make things explode.

@zspencer zspencer force-pushed the 1565/fix-failing-destroy-of-gizmo branch from 48b4e12 to 7de3b0d Compare June 25, 2023 18:05
@zspencer zspencer force-pushed the 1565/write-system-test branch from d344c03 to c3c21dc Compare June 25, 2023 18:40
@zspencer zspencer force-pushed the 1565/fix-failing-destroy-of-gizmo branch from af81af5 to 97c1b81 Compare June 25, 2023 18:43
@zspencer
🐞🔨 Gizmo: Fix bug where removing a Gizmo fails
470c489 
- #1565

OK this is also a bit much; but it does fix the bug. I'm going to try
and tighten it up a bit
@zspencer zspencer force-pushed the 1565/fix-failing-destroy-of-gizmo branch from 97c1b81 to 470c489 Compare June 25, 2023 18:56
@zspencer zspencer marked this pull request as ready for review June 25, 2023 19:02
zspencer added a commit that referenced this pull request Jun 25, 2023
@zspencer
✨🥔 Components: Expose ButtonComponent#danger variant
0095772 
- #1187

As part of #1592 I needed
a Button that used the `dange` variant and all the turbo-y goodness.

So I pulled a variant into the `ButtonComponent`; and then we can search
for `--danger` and purge them.
@zspencer zspencer mentioned this pull request Jun 25, 2023
Merged
@zspencer zspencer requested review from a team June 25, 2023 19:16
KellyAH
KellyAH approved these changes Jun 25, 2023
View reviewed changes
Copy link
Contributor

@KellyAH KellyAH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zspencer zspencer merged commit bcf4e3a into 1565/write-system-test Jun 25, 2023
@zspencer zspencer deleted the 1565/fix-failing-destroy-of-gizmo branch June 25, 2023 19:34
zspencer added a commit that referenced this pull request Jun 25, 2023
@zspencer
✨🥔 Components: Expose ButtonComponent#danger variant (#1596)
9697967 
* ✨🥔 `Components`: Expose ButtonComponent#danger variant

- #1187

As part of #1592 I needed
a Button that used the `dange` variant and all the turbo-y goodness.

So I pulled a variant into the `ButtonComponent`; and then we can search
for `--danger` and purge them.
@zspencer zspencer added 🐞 bug Something isn't working 🔨 Squashed Bugs we think we fixed labels Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KellyAH KellyAH KellyAH approved these changes

Assignees
No one assigned
Labels
🐞 bug Something isn't working 🔨 Squashed Bugs we think we fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zspencer @KellyAH