🌸 Marketplace: Group Delivery Window and Address
#1705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KellyAH
requested review from
zspencer and
anaulin
and removed request for
zspencer
7 tasks
zspencer
approved these changes
Jul 26, 2023
zspencer
changed the title
Marketplace: Group Delivery Window and Address
rosschapman
reviewed
Jul 26, 2023
Comment on lines
+10
to
+11
| <%= delivery.delivery_address if delivery.delivery_address.present? %> | ||
| <%= render(delivery.delivery_area) if delivery.delivery_area.present? %> |
There was a problem hiding this comment.
FYI @KellyAH and I discussed this becoming a small DeliveryWindowComponent.
rosschapman
approved these changes
Jul 26, 2023
|
Maybe we can add heroicons next to the bold text for prettiness. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marketplace:Delivery#1325Marketplace- Improve the checkout experience #1672🍐 w/ @rosschapman
Marketplace- Improve the checkout experience #1672display DeliveryExpectations above deliveryAddress because IMHO it looks better.
Before
Mobile
Desktop
After
Mobile
Desktop
