-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TLS setup #13
TLS setup #13
Conversation
To generate self-signed keys, open /self_signed_certs/ in a terminal and use Running locally, a text-file is retrieved with a browser navigating to https://127.0.0.1:3953/getme and using No testing with |
to clarify the above cli invocation
|
Fixes #9. |
you can also inspect the handshake of the TLS connecting with |
Latest commit is a merge commit, largely modified from previous Now, there is TLS support + tracing. Tracing is not using also updated README. using I see:
on the client side, and
on the server side. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that logs by tracing
are spitting the whole app
before logging the intended message.
I haven't pinpointed where that behavior comes from (might be tracing's default?).
It seems a bit cluttering to me, but I wouldn't block this PR on that anyways.
@ala-mode Do you agree on changing that or is there any big pro of having it that way that I'm missing? Maybe we would like to cap it to DEBUG level logs only?
Besides that, this PR seems fine to me.
Thanks! I don't remember the particulars of the tracing. If we can find a way to streamline, I think that would be great. Because this has been merged, I suggest you open an issue with any details you know right now or fill find out, or just that it's a topic at all, so that we can remember to look into this. |
Different feature branch name, same code as #10 - closed because of issues migrating github repo from private to public which broke our forked personal github repos.
I'll also copy-paste the comments from #10 here.