Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2E: Add parse for invalid address #734

Merged
merged 3 commits into from
Oct 16, 2024
Merged

E2E: Add parse for invalid address #734

merged 3 commits into from
Oct 16, 2024

Conversation

dorianvp
Copy link
Member

This PR adds an E2E detox test inside e2e/send.test.js that validates an invalid address.

@dorianvp dorianvp requested a review from juanky201271 October 16, 2024 20:09
@dorianvp dorianvp self-assigned this Oct 16, 2024
@dorianvp dorianvp marked this pull request as ready for review October 16, 2024 20:14
juanky201271
juanky201271 approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@juanky201271 juanky201271 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job...

@juanky201271 juanky201271 merged commit 00f05b8 into zingolabs:dev Oct 16, 2024
50 of 53 checks passed
@dorianvp dorianvp deleted the e2e_parse_address branch October 17, 2024 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanky201271 juanky201271 juanky201271 approved these changes

Assignees

@dorianvp dorianvp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dorianvp @juanky201271