Added !important suffix for styles #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch! I added some missing tests and created a new PR (#27) with your fixes. A new PR created by me is also necessary cause PR's from forks cannot be tested with Saucelabs due to security restrictions of Travis CI. I'll also create a new PR for the hidden elements fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
visibility -> opacity
visibilityoccupies space and you can click on element behind it. Can be overridden via side-effect in nested blocks.opacityoccupies space, you don't see it but you can not click on elements behind it.!important
When an important rule is used on a style declaration, this declaration overrides any other declarations.
All these changes are working on my project.
@zinserjan, can you merge it?