Removed shadow from iOS screencaps #72
Conversation
|
Awesome! Thanks for this. Just two things before this is ready to merge:
|
|
For sure, let me take a look at that. |
|
Aaand saucelabs is down, so the int tests are failing: https://status.saucelabs.com/incidents/sczxwt2zwz30 |
|
@zinserjan let me know if you want any more changes. |
|
@zinserjan Any more comments? |
|
@jankcat sorry, hadn't any time to review this, yet. Looks good for me. Great job! I think this is ready to merge. But before I'll give it a try on a few projects, probably on wednesday evening. |
|
Oh sure, fair enough. Let me know if it needs more work, I have time the end of this week to do so. |
| } else { | ||
| heightOffset = height - NAV_SHADOW_CONST; | ||
| } | ||
| } |
There was a problem hiding this comment.
Just thought if a if/else-if/else-if/else construct would make the cases more clearly. Maybe in the order "first AND last", "first only", "last only" and "between"?
There was a problem hiding this comment.
Sure let me take a looksie
|
@zinserjan I made the requested changes, I see what you mean about making it easier to understand. |
|
Haha thats a tough one... From a regression standpoint I would say 0.6.0. No apis changed but the output would break visual diffing for sure. |
|
I would also say 0.6.0 to avoid visual regressions. |
|
Hurray! Thanks. |
|
When will you do an npm publish? |
|
wdio-screenshot 0.6.0 published 🎉 Great job @jankcat :) I'll publish also a new version of wdio-visual-regression-service 😉 |
I have removed the shadow from iOS screencaps.
The change essentially just takes slightly overlapping screenshots (scrolling to just above the previous screenshot's bottom edge, as opposed of directly at the edge of the previous screenshot), and then crops half the difference from the bottom of the first screenshot and from the top of the second screenshot.
I took the liberty of running it against my own suite as well, with the following results: