Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spectre integration #66

Merged
merged 20 commits into from
Apr 3, 2018
Merged

Spectre integration #66

merged 20 commits into from
Apr 3, 2018

Conversation

HenningThiemann
Copy link
Contributor

Add support for web-application Spectre

You can try it via:

npm install HenningThiemann/wdio-visual-regression-service#spectre-lib

@emilyrohrbough
Copy link

Any tests for this?

@HenningThiemann
Copy link
Contributor Author

Sorry, no tests so far. Could be difficult to create a test. You have to create a spectre instance that acts as you want it to in a specific situation. In my opinion, there is less use in this because it is a huge overhead

In our environment everything is working fine with this module :)

Henning Thiemann and others added 20 commits March 28, 2018 12:57
@zinserjan
integration of web-application Spectre
cd03773
@zinserjan
fix readme
7ed5ba2
@zinserjan
write run_id.json to current folder to workaround jenkins permission …
3fbc3bf 
…issues
@zinserjan
fix run id
daf988d
@zinserjan
add tests
1db2134
@zinserjan
- send misMatchTolerance to spectre
70f576c 
- use result instead of own calculations for test status
- values are percent
@zinserjan
fix sample
e14bc3d
@zinserjan
introduce new hook onPrepare to create test run id once for all tests
e50dd40
@zinserjan
bump client version
efff766
@zinserjan
remove .only
ba13353
@zinserjan
pass browser url to spectre
6359562
@zinserjan
adjust log messages
10df6f2
@zinserjan
replace misMatchTolerance with fuzzLevel
728ccd8 
fuzzLevel is used in the comparion process, misMatchTolerance is used after the comparison
@zinserjan
allow to override fuzzLevel per command
a53c4a8
@zinserjan
consistent logs
86e06bc
@zinserjan
log url and fuzz
74789df
@zinserjan
split spectreOptions into several methods
86ce8f8
@zinserjan
clean up temporary file
2111638
@zinserjan
fix missing context in example
eaaff25
@zinserjan
fix space
5e0a98d
@zinserjan
Copy link
Owner

I made some changes:

  • added some basic tests
  • added new hooks to make sure a single run id is created for the whole webdriverio run
  • configurable fuzzLevel
  • send url to spectre
  • split spectreOptions into several methods
  • clean up temporary file

@zinserjan zinserjan merged commit 767a1de into zinserjan:master Apr 3, 2018
@zinserjan zinserjan mentioned this pull request Apr 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HenningThiemann @emilyrohrbough @zinserjan