Remove unsafeRun in .toResource, preserve interruptibility of Reservation in Resource. add .toResourceZIO #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion in Resource. add .toResourceZIO
|
@Kaishh you should have it now :) |
|
Thanks! |
neko-kai
requested review from
mijicd,
ghostdogpr,
iravid,
jdegoes and
a team
and removed request for
a team
neko-kai
changed the title
iravid
previously approved these changes
Jun 28, 2019
interop-cats/jvm/src/main/scala/zio/interop/catszmanagedjvm.scala
Outdated
Show resolved
Hide resolved
ghostdogpr
previously approved these changes
Jun 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaks API in a binary-incompatible way by changing required implicits, although I think it's worth it to avoid deadlocking user's program