Fix tailRecM being not stack safe #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
adamgfraser
previously approved these changes
Nov 25, 2021
|
Looks like there are a lot of unrelated changes - or you based it off some old branch 🤔 |
|
Yeah I started my branch from the tag I rebased my branch to |
joroKr21
reviewed
Nov 26, 2021
joroKr21
approved these changes
Nov 26, 2021
adamgfraser
approved these changes
Nov 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #458.
Something to note is that the original implementation passes
tailRecMStackSafetyin cats (https://github.com/typelevel/cats/blob/e0784fc0d95b9c4eed0bb1ddce6c69e3fd9a4a4f/laws/src/main/scala/cats/laws/MonadLaws.scala#L39), which does not givetailRecMa recursive function.This PR doesn't change the semantics in that case, but for the cases where
tailRecMis given a recursive function like intailRecMConstructionStackSafety, it prevents stack overflow during construction.It's tested on v2.5.1.0, so some changes may be necessary to apply this to master.