Upgrade ZIO Interop Cats Effect 3 to ZIO 2.0.0-RC1 #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghostdogpr
approved these changes
Dec 16, 2021
| @@ -64,9 +62,12 @@ private[zio] trait CatsSpecBase | |||
| case infinite: Infinite => | |||
| ZIO.dieMessage(s"Unexpected infinite duration $infinite passed to Ticker") | |||
| } | |||
|
|
|||
| def scheduler(implicit trace: ZTraceElement): UIO[Scheduler] = | |||
| ??? | |||
There was a problem hiding this comment.
This is part of the interface of Clock in ZIO 2.0 so we need to honor the contract though like some of the other methods above it will never be called in tests so we don't actually have to implement it.
| import zio.internal.stacktracer.InteropTracer | ||
|
|
||
| abstract class CatsMtlPlatform extends CatsMtlInstances | ||
|
|
||
| abstract class CatsMtlInstances { | ||
|
|
||
| implicit def zioLocal[R, E](implicit ev: Applicative[ZIO[R, E, _]]): Local[ZIO[R, E, _], R] = |
There was a problem hiding this comment.
@adamgfraser just wondering, why was this and the Ask instance removed? can they not be implemented with ZIO 2.x?
There was a problem hiding this comment.
@lacarvalho91 It can be implemented but needs to build in the ZEnvironment. See #662.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.