Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert change in Command parsing logic #140

Merged
merged 2 commits into from
Nov 4, 2022

Conversation

jorge-vasquez-2301
Copy link
Contributor

Reverting a change I've made in Command parsing logic, because it was causing unwanted behaviour because of change in params order

@jorge-vasquez-2301 jorge-vasquez-2301 requested a review from a team November 4, 2022 15:46
@DamianReeves
Copy link
Contributor

Is it possible to capture the issue you are trying to address in a test?

@jorge-vasquez-2301
Copy link
Contributor Author

@DamianReeves done!

Copy link
Contributor

@DamianReeves DamianReeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DamianReeves
Copy link
Contributor

@DamianReeves done!

Thanks @jorge-vasquez-2301 - Approved

@jorge-vasquez-2301 jorge-vasquez-2301 merged commit d167a81 into zio:master Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants