Make the project zio.cli.sbt/sbt-zio-cli publishable by default
#209
Conversation
| @@ -33,15 +33,16 @@ val zioVersion = "2.0.15" | |||
| lazy val root = project | |||
| .in(file(".")) | |||
| .settings( | |||
| skip / publish := true, | |||
| publish / skip := true, | |||
There was a problem hiding this comment.
Reference: https://www.scala-sbt.org/1.x/docs/Publishing.html#Skip+publishing
The effect of this line is that sbt publish or sbt publishLocal would not generate an artifact named root, which it currently does.
build.sbt
Outdated
| unusedCompileDependenciesFilter -= moduleFilter("org.scala-js", "scalajs-library") | ||
| ) | ||
| .aggregate( | ||
| zioCliJVM, | ||
| zioCliJS, | ||
| examplesJVM, | ||
| examplesJS, | ||
| docs | ||
| docs, | ||
| sbtZioCli, |
There was a problem hiding this comment.
This makes sbt publish or sbt publishLocal include the project sbtZioCli by default, which it currently doesn't.
|
I have pushed a fix for the CI failures. Would you please trigger the CI jobs again. The issue was that the CI jobs were testing each project against each Scala version from 2.12, 2.13, and 3, but the sbt plugin could only be compiled with Scala version 2.12, which is what sbt version 1.* is itself compiled with. |
|
@pablf Cab you fix conflicts? 🙏 |
Currently, `zio.cli.sbt/sbt-zio-cli` is not published in maven.
Upgrade dotty to 3.3.0 to match other zio packages. Use `++version` instead of `++verison!` in the CI, because the latter syntax forces a Scala version for all subprojects ignoring the compatible versions declared in crossScalaVersions. For example; `++3.3.0!` would force the sbt plugin to compile with Scala version 3.3.0, while ++3.3.0 would recognize that the project is incompatible with dotty and skip it. It is crucial to only build the sbt plugin with Scala version 2.12, which is what sbt 1 itself is built with.
To make the CI happy.
|
@jdegoes the conflicts have been resolved. |
closes #203.
The package
zio.cli.sbt/sbt-zio-cliis not currently published in maven. Somebody (other than me) has to publish it.This patch makes it such that
sbt publishwould includezio.cli.sbt/sbt-zio-cliby default. Otherwise, it can be published individually withsbt sbtZioCli/publish.You can test this patch locally with
sbt publishLocal, which would publish the artifacts to the folder~/.ivy2/local/.Regardless of this PR, someone with publishing credentials should publish this package.
/claim #203