optimize path encode method (#1035)

zio · Feb 18, 2022 · b57aa88 · b57aa88
1 parent fea9f23
commit b57aa88
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/zio-http/src/main/scala/zhttp/http/PathModule.scala b/zio-http/src/main/scala/zhttp/http/PathModule.scala
@@ -17,14 +17,15 @@ private[zhttp] trait PathModule { module =>
     final def drop(n: Int): Path = Path(self.toList.drop(n))
 
     final def encode: String = {
-      def loop(self: Path): String = {
+      @tailrec
+      def loop(self: Path, str: String): String = {
         self match {
-          case Path.End              => ""
-          case Path.Cons(name, path) => s"/${name}${loop(path)}"
+          case Path.End              => str
+          case Path.Cons(name, path) => loop(path, s"$str/$name")
         }
       }
-      val result                   = loop(self)
-      if (result.isEmpty) "/" else result
+      val res                                   = loop(self, "")
+      if (res.isEmpty) "/" else res
     }
 
     final def initial: Path = self match {