Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multipart form data server support #1559

Closed
fokot opened this issue Sep 23, 2022 · 4 comments · Fixed by #1953
Closed

Multipart form data server support #1559

fokot opened this issue Sep 23, 2022 · 4 comments · Fixed by #1953
Labels
enhancement New feature or request

Comments

@fokot
Copy link
Contributor

fokot commented Sep 23, 2022

Is your feature request related to a problem? Please describe.
Server can accept and parse Multipart form data requests.

Describe the solution you'd like
Something nice

Describe alternatives you've considered
We can either use https://netty.io/4.0/api/io/netty/handler/codec/http/multipart/InterfaceHttpPostRequestDecoder.html or parse it ourselves in ZIO streams.

@fokot fokot added the enhancement New feature or request label Sep 23, 2022
@fokot
Copy link
Contributor Author

fokot commented Sep 23, 2022

@fokot
Copy link
Contributor Author

fokot commented Sep 23, 2022

I will work on it

fokot added a commit to fokot/zio-http that referenced this issue Oct 29, 2022
fokot added a commit to fokot/zio-http that referenced this issue Oct 31, 2022
@tusharmath
Copy link
Collaborator

There are two ways we can implement it —

  1. Using Netty's multipart-decoder
  2. Using ZIO Parser

We can also decode a FullHttpRequest or an HttpRequest where the body is a stream.

In my opinion, we should move fast on this issue by implementing a non-streaming solution first and decoding it with netty's multipart decoder. That will perform the decoding in memory at once. So it won't work for very large files, but at least build some multipart support in the library.

@vigoo vigoo linked a pull request Feb 13, 2023 that will close this issue
@Tasselmi
Copy link

hi, my friends. any update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants