Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request is missing hasFormMultipartContentType #2215

Closed
domdorn opened this issue May 27, 2023 · 8 comments · Fixed by #2256
Closed

Request is missing hasFormMultipartContentType #2215

domdorn opened this issue May 27, 2023 · 8 comments · Fixed by #2256
Labels

Comments

@domdorn
Copy link

domdorn commented May 27, 2023

a Request already has a hasFormUrlencodedContentType helper method,
but is missing a hasFormMultipartContentType to do a proper check before calling req.body.asMultipartForm

@domdorn domdorn added the enhancement New feature or request label May 27, 2023
@jdegoes
Copy link
Member

jdegoes commented Jun 13, 2023

/bounty $50

@algora-pbc
Copy link

algora-pbc bot commented Jun 13, 2023

💎 $50 bounty created by jdegoes
🙋 If you start working on this, comment /attempt #2215 to notify everyone
👉 To claim this bounty, submit a pull request that includes the text /claim #2215 somewhere in its body
📝 Before proceeding, please make sure you can receive payouts in your country
💵 Payment arrives in your account 2-5 days after the bounty is rewarded
💯 You keep 100% of the bounty award
🙏 Thank you for contributing to zio/zio-http!

Attempt Started Solution
🟢 @abcpro1 Jun 14, 2023 #2256

@abcpro1
Copy link
Contributor

abcpro1 commented Jun 14, 2023

/attempt #2215

@algora-pbc
Copy link

algora-pbc bot commented Jun 14, 2023

💡 @abcpro1 submitted a pull request that claims the bounty. You can visit your org dashboard to reward.
👉 @abcpro1: To receive payouts, sign up on Algora, link your Github account and connect with Stripe on your dashboard.

@domdorn
Copy link
Author

domdorn commented Jun 14, 2023

@abcpro1 did you check your code with a real request? cause a real request does not simply use the content-type, it also includes a boundary parameter in the content-type that marks how body parts are separated, so a strict stringA == stringB comparison does not work, it rather has to be something like actualContentType.startsWith(...) check.
See this for further info:
https://www.w3.org/Protocols/rfc1341/7_2_Multipart.html

@abcpro1
Copy link
Contributor

abcpro1 commented Jun 14, 2023

nope, didn't. I'll check and come back.

@algora-pbc
Copy link

algora-pbc bot commented Jun 15, 2023

@abcpro1: Your claim has been rewarded! 👉 Complete your Algora onboarding to collect the bounty.

@algora-pbc
Copy link

algora-pbc bot commented Jun 15, 2023

🎉🎈 @abcpro1 has been awarded $50! 🎈🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants