Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid printing secrets #2508

Closed
987Nabil opened this issue Nov 7, 2023 · 6 comments · Fixed by #2593
Closed

Avoid printing secrets #2508

987Nabil opened this issue Nov 7, 2023 · 6 comments · Fixed by #2593
Labels
💎 Bounty good first issue Good for newcomers 💰 Rewarded

Comments

@987Nabil
Copy link
Contributor

987Nabil commented Nov 7, 2023

There a different places, where we use plain strings to keep credentials like passwords in memory. To avoid accidental printing to logs/console, we should use a dedicated data structure that will just print *** when toString is called on it.
@987Nabil 987Nabil added the good first issue Good for newcomers label Nov 7, 2023
@987Nabil
Copy link
Contributor Author

987Nabil commented Dec 5, 2023

Should use zio.Config.Secret

@jdegoes
Copy link
Member

jdegoes commented Jan 6, 2024

/bounty $75

To use zio.Config.Secret everywhere for passwords.

@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Jan 6, 2024 •
edited
Loading

💎 $75 bounty created by ZIO
🙋 If you start working on this, comment /attempt #2508 to notify everyone
👉 To claim this bounty, submit a pull request that includes the text /claim #2508 somewhere in its body
📝 Before proceeding, please make sure you can receive payouts in your country
💵 Payment arrives in your account 2-5 days after the bounty is rewarded
💯 You keep 100% of the bounty award
🙏 Thank you for contributing to zio/zio-http!

Attempt Started (GMT+0) Solution
🟢 @987Nabil Jan 6, 2024, 10:57:04 PM #2593

@987Nabil
Copy link
Contributor Author

987Nabil commented Jan 6, 2024 •
edited by algora-pbc bot
Loading

/attempt #2508

Options

987Nabil added a commit to 987Nabil/zio-http that referenced this issue Jan 7, 2024
@987Nabil
Use zio.Config.Secret instead of String to avoid leaks (zio#2508)
87408c0
@987Nabil 987Nabil mentioned this issue Jan 7, 2024
Merged
@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Jan 7, 2024

💡 @987Nabil submitted a pull request that claims the bounty. You can visit your bounty board to reward.

jdegoes pushed a commit that referenced this issue Jan 7, 2024
@987Nabil
Use zio.Config.Secret instead of String to avoid leaks (#2508) (#…
e0423d8 
…2593)
@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Jan 7, 2024

🎉🎈 @987Nabil has been awarded $75! 🎈🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💎 Bounty good first issue Good for newcomers 💰 Rewarded
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use zio.Config.Secret instead of String to avoid leaks (#2508) 987Nabil/zio-http
2 participants
@jdegoes @987Nabil