convert ServerResponseHandler to class.
#1086
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitksingh1490
added
maintenance
Codecov Report
@@ Coverage Diff @@
## main #1086 +/- ##
==========================================
+ Coverage 57.61% 57.64% +0.02%
==========================================
Files 73 73
Lines 2291 2290 -1
Branches 69 67 -2
==========================================
Hits 1320 1320
+ Misses 971 970 -1
Continue to review full report at Codecov.
|
tusharmath
reviewed
Feb 24, 2022
| @@ -13,9 +13,7 @@ import zio.{UIO, ZIO} | |||
| import java.io.RandomAccessFile | |||
|
|
|||
| @Sharable | |||
There was a problem hiding this comment.
Suggested change
| @Sharable |
tusharmath
reviewed
Feb 24, 2022
| private[zhttp] trait ServerResponseHandler[R] { | ||
| def serverTime: ServerTime | ||
| val rt: HttpRuntime[R] | ||
| private[zhttp] final class ServerResponseHandler[R](runtime: HttpRuntime[R], serverTime: ServerTime) { |
There was a problem hiding this comment.
Suggested change
| private[zhttp] final class ServerResponseHandler[R](runtime: HttpRuntime[R], serverTime: ServerTime) { | |
| private[zhttp] final class HttpResponseService[R](runtime: HttpRuntime[R], serverTime: ServerTime) { |
tusharmath
reviewed
Feb 24, 2022
| with ServerResponseHandler[R] { self => | ||
|
|
||
| with WebSocketUpgrade[R] { self => | ||
| type Ctx = ChannelHandlerContext |
There was a problem hiding this comment.
Suggested change
| type Ctx = ChannelHandlerContext | |
| type Ctx = ChannelHandlerContext | |
| val responseService = new ServerResponseHandler[R](zExec, ServerTime.make) |
|
Need to think about the design a little bit more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1085