-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add proxy handler for client API #1226
Conversation
7892e69
to
8f16da2
Compare
8f16da2
to
9af868e
Compare
final case class Proxy( | ||
url: URL, | ||
credentials: Option[Credentials] = None, | ||
headers: Option[Headers] = None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
headers: Option[Headers] = None, | |
headers: Headers = Headers.empty, |
9af868e
to
ab7b527
Compare
Codecov Report
@@ Coverage Diff @@
## main #1226 +/- ##
==========================================
+ Coverage 59.59% 61.71% +2.12%
==========================================
Files 70 71 +1
Lines 2450 2756 +306
Branches 70 92 +22
==========================================
+ Hits 1460 1701 +241
- Misses 990 1055 +65
Continue to review full report at Codecov.
|
@pizzaeueu Can you make the PR wrt |
9d12ca6
to
52fc850
Compare
52fc850
to
af85082
Compare
Hi @tusharmath Target branch was changed to main |
Hi @tusharmath I really need such feature 😌 |
Hi there!
My attempt to provide a solution for #101
Why PR to zio-http 2.x ?
Actually, I don't know the right flow. Please correct me if I need to do it in a different way. I personally need it in 2.x, so that was a motivation 😌
How did you test it?
Result with Proxy
Result without Proxy
Results with wrong proxy address
etc