Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add methods to Endpoint to apply any kind of in/out codec #2142

Merged
merged 1 commit into from
May 5, 2023

Conversation

987Nabil
Copy link
Contributor

@987Nabil 987Nabil commented May 4, 2023

  • add some convenience methods for creating header codecs
  • make text codecs implicit for easy usage in header and query codec

@codecov-commenter
Copy link

codecov-commenter commented May 4, 2023

Codecov Report

Patch coverage: 63.63% and project coverage change: +0.15 🎉

Comparison is base (237861e) 66.71% compared to head (2fd8680) 66.87%.

❗ Current head 2fd8680 differs from pull request most recent head a933181. Consider uploading reports for the commit a933181 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2142      +/-   ##
==========================================
+ Coverage   66.71%   66.87%   +0.15%     
==========================================
  Files         141      141              
  Lines        6033     6040       +7     
  Branches      257      256       -1     
==========================================
+ Hits         4025     4039      +14     
+ Misses       2008     2001       -7     
Impacted Files Coverage Δ
...tp/src/main/scala/zio/http/codec/QueryCodecs.scala 50.00% <ø> (+25.00%) ⬆️
...p/src/main/scala/zio/http/codec/HeaderCodecs.scala 95.69% <20.00%> (-4.31%) ⬇️
...http/src/main/scala/zio/http/codec/TextCodec.scala 77.96% <100.00%> (+6.77%) ⬆️
...tp/src/main/scala/zio/http/endpoint/Endpoint.scala 31.00% <100.00%> (+1.40%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@987Nabil 987Nabil force-pushed the general-codec-method branch from d2a0599 to 2fd8680 Compare May 4, 2023 16:35
- add some convenience methods for creating header codecs
- make text codecs implicit for easy usage in header and query codec
@987Nabil 987Nabil force-pushed the general-codec-method branch from 2fd8680 to a933181 Compare May 4, 2023 16:50
@jdegoes
Copy link
Member

jdegoes commented May 5, 2023

Thank you for your work on this!

@jdegoes jdegoes merged commit 8c59155 into zio:main May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants